…undation#4968)

The JPEG XL color encoding metadata only supports a subset of CICP. So
for
example `srgb_p3d65_display` and `pq_rec2020_display` are supported, but
`g26_xyzd65_display` is not.

Custom primaries, custom white point and arbitrary gamma could be used
to
support more, but I didn't implement that.

Tests for read and write were added.

Signed-off-by: Brecht Van Lommel <brecht@blender.org>
Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
Signed-off-by: Vlad <shaamaan@gmail.com>

…()` (AcademySoftwareFoundation#4987)

Rearrangements in 3.1 dropped the list of recognized attributes from
the visible online docs and failed to document the span varieties. We
fix and also reword a lot of the descriptions for clarity and uniformity.

The previous organization was that there were several varieties of attribute(). In the header, the first one had the overall long explanation, including the list of all the recognized attributes. The other ones had short explanations of how they differed. In the docs, each one was referenced explicitly, pulling in its attendant bit of documentation.

What really happened is that in the header, I made the new span-based version the "flagship" one with the full explanation, but I neglected to reference it in the docs, so the long description disappeared.

I could have fixed by just adding refs to the new functions to the docs, as I originally meant to. But while I was there, I took the opportunity to surround the whole collection with a group marker, and then include the lot of them with a single reference to the group, rather than need to refer to each function variant individually. And while I was at it, I also reworded (and hopefully improved) some of those explanations.

Signed-off-by: Larry Gritz <lg@larrygritz.com>
Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
Signed-off-by: Vlad <shaamaan@gmail.com>

Signed-off-by: Larry Gritz <lg@larrygritz.com>
Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
Signed-off-by: Vlad <shaamaan@gmail.com>

…Foundation#4990)

Implement RLE compression support for the SGI output plugin. Reading RLE
encoded images was already supported, but writing was never done up
until this point.

The existing sgi test seems sufficient to catch issues and it covers
input/output of both 1 byte-per-pixel and 2 byte-per-pixel files.

The documentation for the image plugins are sometimes not very clear
about which attributes are relevant for input vs. output. There's
usually 3 sections: Attributes, Attributes for Input, and Attributes for
Output.

Before this PR, SGI mentioned the "compression" attribute in the
"general" Attributes section (rather than say just the Input section),
which caused a bit of grief as the only way to discover that RLE was not
implemented for Output was to glance at the file size of the resulting
file... I had assumed that compression was supported for output too but
discovered that it was not.

Now that this PR implements the attribute for output I've left the
documentation as-is in the "general" Attributes section since it applies
to both read/writing now. But I'm open for suggestions here.

Signed-off-by: Jesse Yurkovich <jesse.y@gmail.com>
Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
Signed-off-by: Vlad <shaamaan@gmail.com>

Signed-off-by: Larry Gritz <lg@larrygritz.com>
Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
Signed-off-by: Vlad <shaamaan@gmail.com>

Starting with 1.21, libheif seems to change behavior: When no CICP
metadata is present, libheif now returns 2,2,2 (all unspecified) on
read. OIIO convention, though, is to not set the attribute if valid CICP
data is not in the file.

---------

Signed-off-by: Larry Gritz <lg@larrygritz.com>
Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
Signed-off-by: Vlad <shaamaan@gmail.com>

…wareFoundation#4993)

For IBA::resample() when bilinear interpolation is used, almost all of
the expense was due to its relying on ImageBuf::interppixel which is
simple but constructs a new ImageBuf::ConstIterator EVERY TIME, which is
very expensive.

Reimplement in a way that reuses a single iterator. This speeds up
IBA::resample by 20x or more typicaly.

Also refactor resample to pull the handling of deep images into a
separate helper function and out of the main inner loop. And add some
benchmarking.

Signed-off-by: Larry Gritz <lg@larrygritz.com>
Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
Signed-off-by: Vlad <shaamaan@gmail.com>

* CI test vs the latest freetype 2.14.1
* Bump the version of freetype that we auto-build to the latest (from
2.13.2)
* Simplify BZip2 finding logic, switch to using targets

Signed-off-by: Larry Gritz <lg@larrygritz.com>
Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
Signed-off-by: Vlad <shaamaan@gmail.com>

…areFoundation#4998)

The Intel MacOS 15 CI testing is getting dicier... lots of times,
Homebrew doesn't have cached versions of updated packages, so it tries
to build from source, which takes forever. The big culprit today is Qt.
So, basically, just on this one CI job variant, don't ask it to install
Qt. If it's there, it's there. If not, just skip it. It's tested plenty
in other variants.

Signed-off-by: Larry Gritz <lg@larrygritz.com>
Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
Signed-off-by: Vlad <shaamaan@gmail.com>

…cademySoftwareFoundation#4997)

Signed-off-by: Larry Gritz <lg@larrygritz.com>
Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
Signed-off-by: Vlad <shaamaan@gmail.com>

Fixes AcademySoftwareFoundation#5000

Signed-off-by: Brad Smith <brad@comstyle.com>
Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
Signed-off-by: Vlad <shaamaan@gmail.com>

…wareFoundation#4995)

Signed-off-by: Larry Gritz <lg@larrygritz.com>
Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
Signed-off-by: Vlad <shaamaan@gmail.com>

Due to typos in the option name in compiler.cmake (HARDENING vs
OIIO_HARDENING, oops), I think we were never really setting the intended
compiler flags. Fix that all up, and repair the other problems that it
revealed -- some compiler version and option combinations weren't happy
with each other, etc.

One notable change is in encode_iptc_iim_one_tag: I think I made it
safer by taking an early out for 0-sized data, and also it needed a
warning suppression when certain gcc hardening levels were used.

---------

Signed-off-by: Larry Gritz <lg@larrygritz.com>
Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
Signed-off-by: Vlad <shaamaan@gmail.com>

Needed for some systems after the changes of AcademySoftwareFoundation#4963.

Ever so slightly different LSB somewhere makes the hashes not match, but
it's a correct visual result.

Signed-off-by: Larry Gritz <lg@larrygritz.com>
Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
Signed-off-by: Vlad <shaamaan@gmail.com>

…eFoundation#5008)

Signed-off-by: Larry Gritz <lg@larrygritz.com>
Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
Signed-off-by: Vlad <shaamaan@gmail.com>

…ftwareFoundation#5010)

Yay, I love how these things just break with no notice.

Fixes CI that broke a couple days agi.

---------

Signed-off-by: Larry Gritz <lg@larrygritz.com>
Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
Signed-off-by: Vlad <shaamaan@gmail.com>

…areFoundation#5009)

Signed-off-by: Larry Gritz <lg@larrygritz.com>
Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
Signed-off-by: Vlad <shaamaan@gmail.com>

…SoftwareFoundation#5004)

* ImageBuf internal buffer span lacked correct chansize. The internal
`m_bufspan` is an `image_span<byte>`, and as such, it needs to remember
the size of the original data type. Otherwise, there's a cascade of
potential errors when it thinks that the individual values are byte
sized.

* In both ImageInput and ImageOutput, several sanity checks of
image_span size versus expectations were incorrect. They were only
checking if the total byte sizes matched expectations, but they are
allowed to disagree when you consider type conversions (in which case,
it's the total number of values that need to match, not the total byte
sizes.

Signed-off-by: Larry Gritz <lg@larrygritz.com>
Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
Signed-off-by: Vlad <shaamaan@gmail.com>

…ation#5012)

Needed to change the Libheif::Libheif target we set up ages ago to the
"heif" name that the package's exported config uses.

Also, need to give the warning about static libraries occur any time we
are using static libheif, even if we didn't set LIBSTATIC to try to
force all static libraries.

---------

Signed-off-by: Larry Gritz <lg@larrygritz.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
Signed-off-by: Vlad <shaamaan@gmail.com>

…ng (AcademySoftwareFoundation#5005)

We previously merely *marked* tests as "broken" in this case, and
depended on ctest being launched with `-E broken` to ensure those were
skipped. Not everybody did. Let's just truly skip them.

Fixes AcademySoftwareFoundation#4979

Signed-off-by: Larry Gritz <lg@larrygritz.com>
Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
Signed-off-by: Vlad <shaamaan@gmail.com>

…emySoftwareFoundation#5013)

Initializing the encoder to `heif_compression_HEVC` by default throws an
exception when libheif was built without HEVC support, which prevents it
from being used entirely even if there is AVIF support.

So delay that initialization until we are sure which encoding we want.

Not really any practical way to automatically test this.

Signed-off-by: Brecht Van Lommel <brecht@blender.org>
Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
Signed-off-by: Vlad <shaamaan@gmail.com>

…ySoftwareFoundation#5016)

The WebP format is very limited in the maximum resolution it supports.
We need to change the values we allow to be much smaller.

Signed-off-by: Jesse Yurkovich <jesse.y@gmail.com>
Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
Signed-off-by: Vlad <shaamaan@gmail.com>

…areFoundation#5014)

Nearly all IBA functions take an optional parameter controlling the
threading. But make_texture() did not, so there was no way to control
its thread usage (it would always use the default number of threads).

Without changing the call signature or ABI, this patch merely makes
make_texture honor any "maketx:threads" hint passed in the config
ImageSpec that it already takes to convey all sorts of controls over the
texture creation process. Then this value is passed to any IBA
functions, use of parallel_image, and anything else in the
implementation of make_texture that would end up using the thread pool.

Fixes AcademySoftwareFoundation#4254

---------

Signed-off-by: Larry Gritz <lg@larrygritz.com>
Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
Signed-off-by: Vlad <shaamaan@gmail.com>

…SoftwareFoundation#5011)

Utilities to ask the IB for the local pixels as an untyped span of
bytes. This is a "safe" alternative to `localpixels()`, which just
returned a single pointer, instead returning an image_span that
understands the sizes and strides of the buffer.

---------

Signed-off-by: Larry Gritz <lg@larrygritz.com>
Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
Signed-off-by: Vlad <shaamaan@gmail.com>

…ademySoftwareFoundation#5018)

This variable should not have been static.

Signed-off-by: Brecht Van Lommel <brecht@blender.org>
Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
Signed-off-by: Vlad <shaamaan@gmail.com>

…on#5017)

Add IOProxy support similar to other file formats.

MyHeifWriter was renamed for consistency with other code.

All input and output now goes through the proxy, so this is covered by
existing tests.

Signed-off-by: Brecht Van Lommel <brecht@blender.org>
Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
Signed-off-by: Vlad <shaamaan@gmail.com>

Pass the underlying C string to +[NSString stringWithUTF8String:] instead of the std::string object. This fixes an incorrect/ambiguous conversion when creating the Metal shader source NSString in the renderer.

Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
Signed-off-by: Vlad <shaamaan@gmail.com>

Add SPDX headers. Reformat and tidy dnd_glfw.h (includes, spacing, inline function layout, and minor Windows DropTarget refactor) without changing public API. On macOS, stop registering NSFilenamesPboardType and adjust cocoaView bridging to use manual cast/release (fixes retain/release semantics). Small adjustment to GLFW drop-callback setup/assignment formatting.

Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
Signed-off-by: Vlad <shaamaan@gmail.com>

Introduce helper utilities and refactor duplicated Metal OCIO logic: add create_default_compile_options and create_ocio_compile_options; add begin_offscreen_render_pass and end_offscreen_render_pass to centralize command buffer/encoder lifecycle; introduce MetalOcioShaderSourceParts and helper builders (append_ocio_* / build_ocio_shader_call_params / append_texture_binding_source) to construct OCIO shader sources and call parameters; factor texture upload loops into upload_ocio_textures_for_dimension and upload_ocio_non_3d_textures; add bind_ocio_fragment_resources to bind fragment uniforms/textures. Update preview pipeline and OCIO preview program to use these helpers, reducing duplication and improving clarity and error handling.

Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>

Add a new Image List UI (imiv_image_list_ui.*) and a dedicated Preferences window (imiv_preferences_window.cpp), and wire them into the build (imiv_sources.cmake). Replace the previous image_window_title function with an inline constexpr k_image_window_title and update call sites. Move large preference-related UI code out of imiv_aux_windows.cpp into the new preferences file and clean up related helper functions. Update persistence paths to use string literals for legacy filenames, and adjust includes across several modules (developer tools, frame, etc.) to reference the new headers. Also include minor adjustments to test-engine hooks to use the new image title constant and other housekeeping to integrate the new UI components.

Signed-off-by: Vlad <shaamaan@gmail.com>
Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>

Remove small per-backend wrapper functions and wire the vtables to the real ImGui functions and existing helpers. Added renderer_noop_wait_idle and a renderer_call_backend_new_frame template in the header to avoid duplicated no-op/new-frame wrappers. Updated Metal, OpenGL and Vulkan backends to use ImGui_Impl* Shutdown/NewFrame directly and to reference existing functions (e.g. platform_glfw_supports_vulkan, imiv_vulkan_screen_capture). This reduces boilerplate and keeps behavior unchanged.

Signed-off-by: Vlad <shaamaan@gmail.com>

Refactor UI and build sources: remove legacy backend/workspace/image-list/save/vulkan-window modules and update CMake source lists accordingly. Move/centralize preferences UI into imiv_aux_windows.cpp (theme, pixel view, image rendering, OCIO config, backend selector, memory, slideshow and close behavior) and update documentation to reference imiv_vulkan_setup. Add image export/save and OCIO-aware processing routines to imiv_file_actions.cpp and adjust includes across several modules to use imiv_viewer/imiv_workspace_ui. Overall cleanup to consolidate preference, export, and backend selection logic and remove obsolete files.

Signed-off-by: Vlad <shaamaan@gmail.com>

helper functions to obtain/validate backend state (ensure_opengl_backend_state, opengl_window_state, ensure_vulkan_backend_state, vulkan_backend_state) and consolidate repeated null/initialization checks. Replace many explicit backend setup/teardown functions with inline lambdas in the renderer vtables, reducing duplicated code for instance/device/window/surface setup, context backup/restore, frame present and cleanup. Also standardize framebuffer size handling (use renderer_set_framebuffer_size) and adjust texture/create/update flows to use the new helpers and clearer error messages. Overall this simplifies control flow and centralizes error handling for OpenGL and Vulkan backends.

Signed-off-by: Vlad <shaamaan@gmail.com>

Introduce imiv_upload_corpus_smoke.py: a new Python driver that runs batched upload smoke tests by generating per-batch scenarios, invoking the GUI test runner, collecting screenshots and state JSON, validating results, and writing a summary CSV. Update imiv_upload_corpus_smoke_test.sh to call the new driver with batch/timeout options and sensible defaults. Refactor imiv_auto_subimage_regression.py to remove the old internal _run_case helper and add a "baseline" scenario step (and include it when collecting scenario states), so the baseline is produced via the scenario runner rather than a separate invocation. Overall this consolidates per-image logic into a batched workflow and simplifies test orchestration.

Signed-off-by: Vlad <shaamaan@gmail.com>

Create_buffer_resource and create_buffer_with_memory_resource plus make_color_image_memory_barrier to centralize buffer creation, memory allocation/binding and common image memory barrier setup. Replace repeated vkCreateBuffer/allocate_and_bind_buffer_memory and manual VkImageMemoryBarrier constructions across OCIO, preview and texture code with the new helpers to reduce duplication, improve readability, and preserve existing error reporting and debug naming. Updated headers and call sites in imiv_vulkan_ocio.cpp, imiv_vulkan_preview.cpp, imiv_vulkan_texture.cpp and resource utils files accordingly.

Signed-off-by: Vlad <shaamaan@gmail.com>

Include pixel probe info in test state output and make Vulkan resource management more robust.

- imiv_developer_tools.cpp: Write probe fields (probe_valid, probe_pos, probe_channel_count) into the test-engine JSON output so runner tests can inspect probe state.
- imiv_image_view.cpp: Use env_read_int_value to fetch forced probe coordinates and simplify validation logic.
- imiv_vulkan_setup.cpp: Factor repeated destroy logic into small helper functions (shader module, pipeline, pipeline layout, descriptor set layout, descriptor pool, render pass) and use them across cleanup paths; change init_* functions to build resources in a linear, transactional manner (do-break cleanup) so partial failures clean up correctly; ensure shader modules are destroyed on failure and centralize descriptor pool destruction.
- tools/imiv_area_probe_closeup_regression.py: Add _run_runner helper and a two-step test flow: run a pixel-closeup probe to capture probe state JSON (validate probe_valid and probe_pos), then run the area-probe closeup runner. Also add probe_state_path and related checks.

These changes improve testability of the pixel probe feature and harden Vulkan resource lifecycle handling to avoid leaks on error paths.

Signed-off-by: Vlad <shaamaan@gmail.com>